Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Links in the Slice Subtree #3641

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Update Links in the Slice Subtree #3641

merged 3 commits into from
Sep 6, 2023

Conversation

InsertCreativityHere
Copy link
Member

The links have already been updated in the actual slicec and icerpc-slice repos.
This just pulls them in.

@pepone
I remember I messed it up last time, so I figured I'd ask just to make sure, but if I rebase this PR onto main, that's fine right?

pepone
pepone reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@pepone pepone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is fine, just don't squash and merge.

Use a merge commit from the PR.

@InsertCreativityHere InsertCreativityHere merged commit 5e9275a into icerpc:main Sep 6, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepone pepone pepone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InsertCreativityHere @pepone